Consent related update of client - ATS protocol #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2024 16:52
Signed-off-by: Ulf Bjorkengren <[email protected]>
Signed-off-by: Ulf Bjorkengren <[email protected]>
tguild
reviewed
Jan 9, 2024
spec/VISSv2_Core.html
Outdated
| @@ -1060,6 +1060,16 @@ <h2>Access Grant Response</h2> | |||
| <section id="access-token-request"> | |||
| <h2>Access Token Request</h2> | |||
| <p> | |||
| The client may have to issue several requests before an access token can be obtained, even in the case of having a valid access grant token. | |||
| The reason for this is that if a consent is required, the ATS will forward the consent request to the External Consent Framework, | |||
There was a problem hiding this comment.
"if a consent" may read better as "if consent"
tguild
reviewed
Jan 9, 2024
spec/VISSv2_Core.html
Outdated
| The reason for this is that if a consent is required, the ATS will forward the consent request to the External Consent Framework, | ||
| and it is likely that there will not be an immediate response from the ECF. | ||
| The ATS will then on the initial access token request respond to the client with a session handle that the client must use in subsequent requests for the access token. | ||
| When the ATS has obtained a consent reply from the ECF it can in the thereafter following client inquiry request in the case of a positive consent |
There was a problem hiding this comment.
instead of "in the thereafter" simply "thereafter" combined with in the sounds like how people refer to heaven or other religious concepts of afterlife :)
There was a problem hiding this comment.
:). Fixed IRL, and not in the thereafter.
tguild
reviewed
Jan 9, 2024
spec/VISSv2_Core.html
Outdated
| an immediate response is not possible, and the response to an initial access token request shall contain the parameter: | ||
| <ul> | ||
| <li>Session handle: A reference to the initial access token request that can be used by the client in subsequent inquiry requests.</li> | ||
| <li>Consent status: There is at this point not any consent status eceived from the EF, so consent status is set to NOT_SET.</li> |
There was a problem hiding this comment.
missing r on received and C for ECF
tguild
reviewed
Jan 9, 2024
spec/VISSv2_Core.html
Outdated
| <h2>Access Token Response To Inquiry Access Token Request</h2> | ||
| <p> | ||
| There are three different responses possible to an inquiry access token request.<br> | ||
| In the case that there is still no consent reply availablefrom the ECF, the response is identical to the response to the initial access token response, see above.<b> |
There was a problem hiding this comment.
missing space between available and from. I think this is also the first occurrence of ECF and should have the expanded version of the acronym being introduced
There was a problem hiding this comment.
Fixed. ECF added to Definitions.
Signed-off-by: Ulf Bjorkengren <[email protected]>
Signed-off-by: Ulf Bjorkengren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Access token request/response protocol have been updated to support the fact that obtaining consent from the data owner is typically a slow process.
A rendered version of the update can be found on this link:
https://rawcdn.githack.com/UlfBj/automotive/4655030c17e3e30c9cf0a7570b7d591380914561/spec/VISSv2_Core.html#access-token-request