Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arraybuffer-base64 and digital identities specs #1204

Merged
merged 13 commits into from
Feb 19, 2024
Merged

Add arraybuffer-base64 and digital identities specs #1204

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
afb228c
Allow to use null value to override bogus seriesVersion calculation
dontcallmedom Feb 12, 2024
4385db0
Fix regexp in version calculation
dontcallmedom Feb 12, 2024
12ead8e
Add discourse archive to ignore list
dontcallmedom Feb 12, 2024
f143d06
Add arraybuffer-base64 and digital identities specs
dontcallmedom Feb 12, 2024
b7c4c6e
Allow null as a value for seriesVersion
dontcallmedom Feb 12, 2024
0be7f91
Remove lint
dontcallmedom Feb 12, 2024
b7850b9
Remove lint
dontcallmedom Feb 12, 2024
552042b
Revert "Allow to use null value to override bogus seriesVersion calcu…
dontcallmedom Feb 19, 2024
0209911
Revert "Allow null as a value for seriesVersion"
dontcallmedom Feb 19, 2024
b99c5be
Add seriesVersion exception for shortname ending with base64
dontcallmedom Feb 19, 2024
eec98cd
Skip seriesVersion for tc39.es specs
dontcallmedom Feb 19, 2024
bb940c2
Need to compute shortname check for ecma402
dontcallmedom Feb 19, 2024
1f8b67c
Base series version exception logic on shortname and not URL
tidoust Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions specs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,16 @@
},
"https://tc39.es/proposal-array-from-async/",
"https://tc39.es/proposal-array-grouping/",
{
"url": "https://tc39.es/proposal-arraybuffer-base64/spec/",
"series": {
"shortname": "tc39-arraybuffer-base64"
},
"shortname": "tc39-arraybuffer-base64",
"nightly": {
"sourcePath": "spec.html"
}
},
"https://tc39.es/proposal-arraybuffer-transfer/",
"https://tc39.es/proposal-async-explicit-resource-management/",
{
Expand Down Expand Up @@ -578,6 +588,7 @@
"https://wicg.github.io/datacue/",
"https://wicg.github.io/deprecation-reporting/",
"https://wicg.github.io/digital-goods/",
"https://wicg.github.io/digital-identities/",
"https://wicg.github.io/direct-sockets/",
"https://wicg.github.io/document-picture-in-picture/",
"https://wicg.github.io/document-policy/",
Expand Down
3 changes: 2 additions & 1 deletion src/compute-shortname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ function completeWithSeriesAndLevel(shortname, url, forkOf) {
// digits, as in "iso18181-2".
if (seriesBasename.match(/^ecma-/) ||
seriesBasename.startsWith("iso") ||
seriesBasename.endsWith("base64") ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I was thinking of a more generic "no series version for TC39 proposals" exception, since in practice these proposals do not, and should not, contain any version number.

Looking into it, the exception could actually be "no series version for TC39 specs" since, at least for now, we don't try to keep track of versions of TC39 specs:

Suggested change
seriesBasename.endsWith("base64") ||
url.match(/^https:\/\/tc39\.es\//) ||

This also allows to drop the first seriesBasename.match(/^ecma-/) exception as underlying URLs also start with https://tc39.es/.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much more elegant, indeed :) will fix

Maybe the generalization of this is using an allowlist for organizations that do use series version? (or a blocklist of the reverse); that's probably not practical at compute-shortname stage, but could be done in a clean up phase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well, the approach based on the URL is not going to work as-is, due to the fact that shortname was made explicit, which effectively replaces the URL in the call to computeShortname. See #1219.

I'll update to a check on the shortname instead.

url.match(/^https:\/\/registry\.khronos\.org\/webgl\/extensions\//)) {
return {
shortname: specShortname,
Expand All @@ -188,7 +189,7 @@ function completeWithSeriesAndLevel(shortname, url, forkOf) {

// Extract X and X.Y levels, with form "name-X" or "name-X.Y".
// (e.g. 5 for "mediaqueries-5", 1.2 for "wai-aria-1.2")
let match = seriesBasename.match(/^(.*?)-v?(\d+)(.\d+)?$/);
let match = seriesBasename.match(/^(.*?)-v?(\d+)(\.\d+)?$/);
if (match) {
return {
shortname: specShortname,
Expand Down
3 changes: 3 additions & 0 deletions src/data/ignore.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@
"WICG/close-watcher": {
"comment": "merged into HTML"
},
"WICG/discourse-archive": {
"comment": "not a spec"
},
"WICG/priority-hints": {
"comment": "merged into HTML"
},
Expand Down