Rework handling of fully active status #276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #275, where it is explained that the current model of activating
data delivery again when a document becomes fully active is unclear.
Furthermore, doing the same thing to workers based on whether they are
active needed workers or not does not have precedent in other specs and it
is not clear if the current steps even work or not.
Instead, do the following:
point to Properly determine bfcache integration strategy #275.
again for symmetry (and also because it is not clear if it can become an
active worker again once it it stops being so).
the "Handling change of fully active" one.
the "unloading document cleanup steps" are how specs are supposed to
react to a document no longer being fully active.
a check for the value of the
closing
flag in WorkerGlobalScope.be performed in both cases.
Preview | Diff