Add support for ownContributionEstimate #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arskama
reviewed
Nov 15, 2024
There was a problem hiding this comment.
typo in the title: %s/supp0rt/support/
Otherwise I think the PR is fine.
One question I would ask to more experienced API developers:
- Is
doublea good type for an estimate in percent?
It is an estimate in percent, so an readonly attribute octet should be enough, but I m not sure how widely it is used in WebAPIs
|
I checked existing APIs and all examples use double |
A percentage estimate for the contribution of the site to the global pressure
|
I m ok with the PR, but I wish someone else would take a look as well. |
|
I'm ok with the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A percentage estimate for the contribution of the site to the global pressure
Fixes #297
Preview | Diff