Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @supports and @viewport (without checking) #174

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Feb 15, 2018

This change is a temporary workaround that adds an interim/initial/partial level
of support for allowing the @supports and @Viewport at-rules. The intent is that
we’ll add full support for them later, and then at that time back this change
out (because adding real, full support will make it unnecessary).

This change simply causes no errors to be reported for stylesheets that use
@supports and @Viewport. Beyond that, it doesn’t add any checking to report an
error if the content of a particular @supports at-rule or @Viewport at-rule
doesn’t conform to the requirements in the relevant CSS specs.

Addresses #71

@sideshowbarker sideshowbarker force-pushed the sideshowbarker/viewport-and-supports-at-rules-interim-support branch 3 times, most recently from d6bffbd to b134d91 Compare February 15, 2018 11:14
This change is a temporary workaround that adds an interim/initial/partial level
of support for allowing the @supports and @Viewport at-rules. The intent is that
we’ll add full support for them later, and then at that time back this change
out (because adding real, full support will make it unnecessary).

This change simply causes no errors to be reported for stylesheets that use
@supports and @Viewport. Beyond that, it doesn’t add any checking to report an
error if the content of a particular @supports at-rule or @Viewport at-rule
doesn’t conform to the requirements in the relevant CSS specs.

Addresses #71
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/viewport-and-supports-at-rules-interim-support branch from b134d91 to bb3c3be Compare March 10, 2018 23:55
@ylafon
Copy link
Member

ylafon commented Mar 25, 2018

Obsoleted by #183 and #185 that also adds checking.

@ylafon ylafon closed this Mar 25, 2018
@sideshowbarker sideshowbarker deleted the sideshowbarker/viewport-and-supports-at-rules-interim-support branch March 26, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants