-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WotThing and WotDirectory service types #486
Conversation
It seems validation failed. I'm trying to figure out from the error messages whether this is something we caused (and can fix) or if it's an unrelated problem. If I need to fix something please let me know... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registrations should NOT contain contain URLs that 404, people will copy paste from these examples.
This comment was marked as resolved.
This comment was marked as resolved.
We are still working on the URL, we will be working to resolve the 404 (and may also have to update our examples). Please hold on merging this PR, we will update once the URL has been finalized and populated. See also w3c/wot-discovery#463 |
The WoT TD spec uses "2022" as the year so for consistency we have used that as the namespace for Discovery also. Yes, "ns" would make more sense but we at least want Discovery and TD context files to be consistent, and the WoT TD files are already published. Publication of WoT Discovery ontology files are pending.
to avoid a conflict with ontology used for WoT Directory itself...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR contains broken links.
Conflicts exist. |
Closing due to inactivity, feel free to open a fresh PR for review any time. |
Please reopen, we do plan on working on this now. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language tweaks for clarity
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Changes accepted, please consider finalizing. Thanks! |
@OR13 URLs should resolve now, addressing the issue you raised. Can you please check? Thanks. |
What is the status on this PR? Do you have a timeline on when it will be merged? It is not critical to our schedule but I would like to know when I can stop checking to make sure it is still mergeable, etc. At this point as far as we know it is ready to merge. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Hey @mmccool -- our deep apologies wrt. how ridiculously long it took to merge this PR. As you know, we hit chartering issues two years ago and have only now just gotten our new Charter approved. The DID Maintenance WG is under way now and we're clearing our backlog of PRs. Thank you for your patience, future PRs won't take nearly as long to get merged. |
This PR is registering the WotThing and WotDirectory service types to be used by Web of Things (WoT) Discovery. The specification for WoT Discovery is being developed by the W3C Web of Things WG and is just entering CR:
There is a proposed URL for a JSON-LD context file but the context file has not yet been published. We are proposing using a special context file for this purpose rather than adding these definitions to an existing context file to keep it short, hence the "did" suffix on the URL. The specs above do not include this context file and it will have to be added (since we are going to be in CR we are going to have to ask for permission...).
Linked issue in WoT Discovery repo: 402
Contact: Michael McCool (@mmccool)
Preview | Diff