Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor editorial changes #124

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Minor editorial changes #124

wants to merge 2 commits into from

Conversation

iherman
Copy link
Member

@iherman iherman commented Feb 20, 2025

(While reviewing the spec.)

  • Copied some CSS for simple tables from the DID core spec. Made the tables more readable (with alternate colors, visually separating the rows)
  • The reference to did core should use the respec/specref pattern using data-cite, to be in line with other usages.

Preview | Diff

Copy link
Collaborator

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this addresses #112 ?

Just wondering if the data-cite should be using did-core#... or DID#... ?

@iherman
Copy link
Member Author

iherman commented Feb 20, 2025

Just wondering if the data-cite should be using did-core#... or DID#... ?

yes, did# (or DID#) is an alias to did-core in specref, so it is a possibility, but it also does not really change anything. It is a matter of taste, really.

The question is rather whether we want, at some point, refer to did-1.1 (which is now in specref for a WD) instead of the 1.0 version. That is a WG question, that I did not want to decide on. The question is whether we will ever depend on specifically 1.1 features

(At some point, when DID 1.1 becomes a rec, I would expect did-core (or did) to refer to 1.1.)

@wip-abramson
Copy link
Contributor

Thanks, I think this addresses #112 ?

This does partly address #112, although there are similar issues in the terms.html file. Perhaps @iherman you can catch those too in this PR?

@iherman
Copy link
Member Author

iherman commented Feb 20, 2025

Thanks, I think this addresses #112 ?

This does partly address #112, although there are similar issues in the terms.html file. Perhaps @iherman you can catch those too in this PR?

Oops, I did not realize there is also another file. My bad. I have just updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants