-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/revise popover related attribute mappings #481
Closed
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
39ae862
revise popover related attribute mappings
scottaohara e4694e5
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara 9eed4ec
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara 5fde9c0
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara cbd0cc6
Update index.html
scottaohara 4cad167
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara e64eaae
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara 0a3851e
update ia2/atk mappings
scottaohara 5829073
Update index.html
scottaohara 75d44ff
Update index.html
scottaohara 4691b00
Update index.html
scottaohara ed8270a
Update index.html
scottaohara 82b42e3
Update index.html
scottaohara 2b36d6f
move details-roles:popover to correct attr table
scottaohara bfa65de
Update index.html
scottaohara bcdb24e
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara beccc2c
Update index.html
scottaohara ce1773d
Update index.html
scottaohara 7ed1441
Update index.html
scottaohara 1fde1de
Update index.html
scottaohara bf0a2fe
Update index.html
scottaohara fd42971
Update index.html
scottaohara 5e31f10
Merge branch 'gh-pages' into popover-attr-mappings
scottaohara 44d2432
Update index.html
scottaohara 71c0c0b
Update index.html
scottaohara fcdd9ac
Update index.html
scottaohara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to be implemented in Chromium:
data:text/html,<button popovertarget="pop">tog</button><div id="pop" popover>pop<button popovertarget="pop" popovertargetaction="hide">hide
When the popover is shown, the "hide" button gets the expanded state. If I'm reading this correctly, it shouldn't.
Just to double check, is this definitely what we want and it just hasn't been done in Chromium yet? Or is this still an open question we need to sort out in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should not be getting the expanded state for the hide button, this will need to be adjusted in chromium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we filed a bug for this?