Define "speaker-selection" powerful feature types and algorithms. #128
Conversation
@sidvishnoi is this related to w3c/spec-prod#99? |
|
the problem was that this repo was using an outdated version of spec-prod - if you rebase on top of 87253ea the error should be gone |
This comment has been minimized.
This comment has been minimized.
Cool, thanks @dontcallmedom (and @sidvishnoi) |
miketaylr
force-pushed
the
permissions-integration
branch
from
b7dd8aa
to
9529020
Compare
|
@jan-ivar given that this permission is common to Media Capture and Streams, and that generally speaking that is where most of the privacy/permission framework is defined, my sense is that this would better be integrated there than in Audio Output - do you agree? |
|
I plan on making a similar PR to Media Capture and Streams, to do the same thing for "camera" and "microphone". If y'all would prefer that all 3 live in the same spot, works for me. |
|
I guess my point of Media Capture and Streams was more specifically about the IDL bits (which presumably should only live in a single place) |
|
Agree. |
|
To clarify, the non-webidl bits (Permissions Integration) in this PR specific to "speaker-selection" seem fine to leave here. |
miketaylr
force-pushed
the
permissions-integration
branch
from
34bbdfc
to
1b659c2
Compare
|
OK, I've pulled out the IDL and will work on a PR for mediacapture-main. It's probably good to land them together. |
|
@jan-ivar is this one fine to land as well, or is something blocking/missing? |
|
@dontcallmedom who is the best person to review this? It would be nice to get it merged. |
There was a problem hiding this comment.
Thanks for doing this integration work, and sorry for the delay!
Having the text consolidated here sure helps in seeing how things should work. I think a couple of changes are needed in the prose, for it to be accurate. I've outlined them below.
I'd also like @youennf to review this, to make sure I didn't miss anything.
No worries, life gets busy. :) The prose was just moved over from the Permissions spec and not authored by me. Not entirely sure of the history there, but let's see if we can't improve it. |
Co-authored-by: Jan-Ivar Bruaroey <[email protected]>
|
I'm committing with those changes. Let's get this merged. |
Awesome - thanks! |
|
(for some reason my suggestion in #128 (comment) didn't take, so I pushed that as a manual follow-up) |
As part of w3c/permissions#263, we're moving each powerful feature to be defined in its parent spec, rather than treat Permissions as a registry.
(also, w3c/permissions#320)
cc @marcoscaceres
Preview | Diff
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Feb 10, 2022, 6:35 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.