-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setPositionState: Explicit means to "clear" or reset. #315
Comments
I don't think this is valid to pass a null dictionary member as a method argument, WebKit implementation should probably be updated. I think Chrome is supporting both If we agree on this, one possible WebIDL is:
|
Is there a reason WebKit needs to throw on
|
@steimelchrome, what you propose (with addition of @youennf's defaults) sounds quite reasonable to me and, as @youennf points out, it indeed does away with the need for We can update WebKit to match. Would you match it in Chrome? |
I think the |
Yes, that would make sense, and it would be easy to enforce. |
As part of #304, when calling
setPositionState(state)
we are having to do some WebIDL/prose gymnastics in order to "clear" the position.In WebKit, there is support for passing
null
instead as a means of clearing the position state. It might be good to also add that in the spec to make clearing the position more ergonomic.The text was updated successfully, but these errors were encountered: