Update MediaPositionState WebIDL #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
force-pushed
the
update-MediaPositionState
branch
2 times, most recently
from
f2a317d
to
31f3cf7
Compare
youennf
force-pushed
the
update-MediaPositionState
branch
from
31f3cf7
to
00da359
Compare
|
@marcoscaceres, @steimelchrome, PTAL |
chrisn
reviewed
Oct 24, 2023
marcoscaceres
requested changes
Dec 22, 2023
marcoscaceres
approved these changes
Jan 11, 2024
It is probably worth an issue. Implementations do clear in case of setPositionState() so I am not sure we can break this. |
|
Ok, filed #315 ... can follow up on that. |
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
steimelchrome
approved these changes
Jan 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Jan 22, 2024
SHA: 42221de Reason: push, by youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 7, 2024
Update for the spec change w3c/mediasession#304 Bug: 324153759 Change-Id: I006b079954cdb5818e97200b65e6ea42333ad6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5274534 Reviewed-by: Tommy Steimel <[email protected]> Commit-Queue: Yiren Wang <[email protected]> Reviewed-by: Matthew Denton <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257586}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303
Fixes #252
We make duration a required member of MediaPositionState and add default values for position and playbackRate. duration is now unrestricted to allow Infinity, we add a special check for NaN.
We update MediaSession.setPositionState to accept null since MediaPositionState now has a required member.
This overtakes #303 and should fix #303 and #252.
Preview | Diff