-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Browser Permissions for WebDriver BiDi #425
Conversation
So that they can be referenced from other specs. Bug: #506 Bug: #587 Bug: w3c/permissions#425
cc @OrKoN @mathiasbynens @jgraham @whimboo (I don't have permissions to change the "assignee" field directly) |
So that they can be referenced from other specs. Bug: #506 Bug: #587 Bug: w3c/permissions#425
cc @miketaylr could you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that if you were to place WebDriver-Bidi after WebDriver, this would be a bit easier to review.
Also, can you fix the build errors?
Converting this back to draft until I apply all requested changes (from both here and https://www.w3.org/2023/11/08-webdriver-minutes.html#t04). |
Ongoing: exporting terms from the webdriver classic spec: |
@jgraham @whimboo Does Mozilla / Firefox / Gecko intend to support the browser permissions API for BiDi? If yes, then could you please file a bug and edit the first comment to include it? Extension modules are optional anyway. |
@gsnedders @patrickangle Does Apple / WebKit intend to support the browser permissions API for BiDi? If yes, then could you please file a bug and edit the first comment to include it? Extension modules are optional anyway. |
I believe all suggestions were addressed. PTAL |
https://www.youtube.com/watch?v=RlJM8-7IMBM (let me try to clean this up before reviewing) |
If the rebase ends up being straightforward, feel free to merge it (or I can do it). If there are any follow-ups, Alex (orkon) will take over from here. Thanks! |
I have opened a PR with the rebase here #431 since I have no permissions to @thiagowfx fork. Let's close this PR in favor of the new PR. |
Sounds good. |
Based-on: w3c/webdriver-bidi#590
Bug: #424
Bug: w3c/webdriver-bidi#587
Upstream auto-linking blockers:
Other considerations:
<jgraham_> (don't want to extend this topic further, but I always assumed BiDi would move to an event-based model for permissions i.e. you'd get a permissions.Request event with some information):This is out of scope of this initial PR. We intend to only achieve feature parity with WebDriver classic.
The following tasks have been completed:
ModifiedWeb platform tests commitment (link): Umbrella bug for WebDriver BiDi Browser Permissions API tests web-platform-tests/wpt#43305Implementation commitment:
Preview | Diff