Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken links to externally defined terms #179

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix broken links to externally defined terms #179

merged 2 commits into from
Oct 17, 2023

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Oct 5, 2023 •
edited by pr-preview bot
Loading

@pchampin
Copy link
Contributor Author

pchampin commented Oct 5, 2023

NB: links to @msporny's and @dlongley's homepages are also broken

dlongley
dlongley approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use https://github.com/dlongley as a non-broken link for me.

gkellogg
gkellogg approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the citation errors

yamdan
yamdan approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@yamdan yamdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchampin pchampin mentioned this pull request Oct 6, 2023
Closed
@gkellogg
Copy link
Member

I took the liberty of updating personal links for both @dlongley and @msporny. Please create a suggestion if you would prefer something else.

msporny
msporny reviewed Oct 17, 2023
View reviewed changes
spec/index.html
@@ -42,7 +42,7 @@
// only "name" is required
formerEditors: [
{ name: "Manu Sporny",
url: "http://manu.sporny.org/",
url: "https://github.com/msporny",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: "https://github.com/msporny",
url: "https://www.linkedin.com/in/manusporny/",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, pulled the trigger too quickly; can you do a new PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0503fac.

@gkellogg gkellogg merged commit a78fc46 into main Oct 17, 2023
2 checks passed
@gkellogg gkellogg deleted the fix-broken-links-2 branch October 17, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny left review comments

@gkellogg gkellogg gkellogg approved these changes

@yamdan yamdan yamdan approved these changes

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pchampin @gkellogg @msporny @dlongley @yamdan