Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add errata page #209

Merged
merged 3 commits into from
May 14, 2024
Merged

add errata page #209

merged 3 commits into from
May 14, 2024

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented May 8, 2024

The errata page is required to go to REC.

I'm reusing the infrastructure developed by Ivan, which is the same used by JSON-LD (among others).


Preview | Diff

@pchampin pchampin mentioned this pull request May 8, 2024
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@yamdan yamdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pchampin and @TallTed . I have added a few editorial suggestions.

errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
errata/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/various suggestions made by others.

Copy link
Contributor

@yamdan yamdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with suggestions.

errata/index.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented May 10, 2024

@pchampin, do you think it would be possible to apply these changes to the 'core' version of the software? I may be as simple as moving the text back to that repository with some minor changes...

(I am happy to do that if you prefer, once I am back in office, so to say...)

@iherman iherman self-requested a review May 10, 2024 07:09
Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with suggestions from @TallTed applied (very helpful as usual)!

Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Dan Yamamoto <[email protected]>
@pchampin
Copy link
Contributor Author

@pchampin, do you think it would be possible to apply these changes to the 'core' version of the software? I may be as simple as moving the text back to that repository with some minor changes...

(I am happy to do that if you prefer, once I am back in office, so to say...)

+1

@pchampin
Copy link
Contributor Author

@TallTed, thanks a lot for these suggestions. Are you happy with the current state of the PR?
(NB, I'll rebase #210 on top of this).

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one more comma

errata/index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@pchampin pchampin merged commit 9e97436 into main May 14, 2024
2 checks passed
@pchampin pchampin deleted the add-errata branch May 14, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants