fix: don't break with multiple specs, add ARTIFACT_NAME option
#180
Conversation
From v4, actions/upload-artifact requires each invocation to have a unique artifact name. Add a new input option to allow the name to be changed so spec-prod can be invoked multiple times.
There was a problem hiding this comment.
This is great @oliverdunk! Can you also add docs to docs/options.md, perhaps at the end of document?
sidvishnoi
changed the title
ARTIFACT_NAME option
sidvishnoi
changed the title
ARTIFACT_NAME optionARTIFACT_NAME option
|
@oliverdunk Can you also verify it works fine by using it in a PR (perhaps for w3c/webextensions#596) before I merge this PR? |
Good call, done! I added it in the middle to be consistent with the ordering in the YML but feel free to move. |
I tested it here which is hopefully a good enough dry run: https://github.com/oliverdunk/webextensions/actions/runs/8706490856/job/23879164260 If you'd really like to see it run in the main repository, let me know and happy to do that. |
|
Brilliant! That dry run is more than enough. Thanks for the PR @oliverdunk! |
SHA: 5cf6473 Reason: push, by sidvishnoi Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
In v2.11.0,
actions/upload-artifactwas updated to v4 which started to cause issues in the WebExtensions Community Group repository. In particular, v4 requires each invocation to have a unique artifact name (this was a breaking change) and that does not hold true when using spec-prod since there is no way to configure the name.Configuration / Example failure
To resolve this, add a new input option to allow the name to be changed. After playing around for a bit this seemed like the simplest solution that would work for everyone :)
Preview | Diff