Reintroduce segment-completing closepath as a theoretical concept #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we use it to define the equivalent paths of basic shapes. I've changed the terminology to refer to the segment-completing close path as an _operation_ instead of a _command_, and have added a short sub-section defining it. I also included a very short note about the proposal for adding it to the path data syntax, in a future version of the specification.
AmeliaBR
requested review from
ewilligers,
dirkschulze,
svgeesus and
Tavmjong
svgeesus
approved these changes
Sep 6, 2018
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we use it to define the equivalent paths of basic shapes.
I've changed the terminology to refer to the segment-completing close path as an operation instead of a command, and have added a short sub-section defining it.
I also included a very short note about the proposal for adding it to the path data syntax, in a future version of the specification.
This fixes build problems introduced by PR #398.
@ewilligers can you take a look at the new text I've added & let me know if you think it works to patch over the disconnect.