<path d> parsing spec needs a special case to not use CSS syntax #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the spec literally before this changes, https://svgwg.org/svg2-draft/styling.html#PresentationAttributes specifies that all presentation properties are parsed according to https://svgwg.org/svg2-draft/types.html#presentation-attribute-css-value For the `d` property, this means the CSS grammar `none | <string>`. The following would be valid: * `<path d="none">` * `<path d="'M 100 100 L 300 100 L 200 300 z'">` (not the single quotes) * `<path d="/**/'M 100 100 \L \33 00 100 L 200 300 z'">` (equivalent to the previous) But `<path d="M 100 100 L 300 100 L 200 300 z">` or indeed any SVG 1.1 path would not be valid because they parse as CSS ident and number tokens, not as a `<string>`. w3c#320 poposes changing the syntax of the `d` CSS propery to be even further to the 1.1 attribute syntax. This does not appear to be an intentional change from SVG 1.1, so this pull request "reverts" it.
|
There is an open pull request that is waiting for review about fixing/clarifying the I suspect your concerns are still valid, but if you're able to, it would be helpful if you compared your fixes against those changes. |
|
#374 fixes the same bug that this PR does, in a way that I find satisfactory. It also contains a normative change |
|
Ok, thanks for checking Simon, and thanks for the effort of the PR even if it turned out to be a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the spec literally before this changes, https://svgwg.org/svg2-draft/styling.html#PresentationAttributes specifies that all presentation properties are parsed according to https://svgwg.org/svg2-draft/types.html#presentation-attribute-css-value
For the
dproperty, this means the CSS grammarnone | <string>.The following would be valid:
<path d="none"><path d="'M 100 100 L 300 100 L 200 300 z'">(not the single quotes)<path d="/**/'M 100 100 \L \33 00 100 L 200 300 z'">(equivalent to the previous)But
<path d="M 100 100 L 300 100 L 200 300 z">or indeed any SVG 1.1 path would not be valid because they parse as CSS ident and number tokens, not as a<string>.#320 poposes changing the syntax of the
dCSS propery to be even further to the 1.1 attribute syntax.This does not appear to be an intentional change from SVG 1.1, so this pull request "reverts" it.