-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multibase datatype definition #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small language tweaks
Forgive me if my question reveals my missing knowledge, but shouldn't this be the range of |
Yes, good catch, I'll make that change in a future revision to this PR. |
ef56135
to
3c91a61
Compare
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR addresses #162 (comment) by defining the
multibase
datatype as we recently did forcryptosuiteString
. It then updatesproofValue
's range to bemultibase
.@iherman, we'll need to define the datatype in the vocabulary.yml file as well, but I didn't see how that was done for
cryptosuiteString
yet -- perhaps that still needs to be merged?Preview | Diff