Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the multibase datatype section #304

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

iherman
Copy link
Member

@iherman iherman commented Aug 20, 2024

When aligning with the controller specification, the section defining the multibase datatype was not removed. That datatype is now formally defined in the controller document (the formal vocabulary has already been changed).

Also, I have added a minor node making it clear that the context and vocabulary files, referred to in the section on contexts and vocabularies (§ 2.4) also includes terms defined in the controller document.


Preview | Diff

@iherman iherman self-assigned this Aug 20, 2024
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me. I'll note that this link:

https://github.com/w3c/vc-data-integrity/blob/main/vocab/security/vocabulary.yml#L277

Seems to be broken and should perhaps go to: https://www.w3.org/TR/controller-document/#assertion

Instead?

@iherman
Copy link
Member Author

iherman commented Aug 20, 2024

This seems ok to me. I'll note that this link:

https://github.com/w3c/vc-data-integrity/blob/main/vocab/security/vocabulary.yml#L277

Seems to be broken and should perhaps go to: https://www.w3.org/TR/controller-document/#assertion

Oops, that was the result of that historical anomaly of having "assertion" in the text and "assortionMethod" in the vocabulary. Which means that the remark on how the terms are defined in the controller document change in w3c/controller-document#43 is actually incorrect, will have to change that...

@msporny
Copy link
Member

msporny commented Aug 24, 2024

Editorial, multiple reviews, changes requested and made, no objections (and unlikely to occur), merging so that merge conflicts don't appear as I do my final editorial pass on the document.

@msporny msporny merged commit bb23860 into main Aug 24, 2024
2 checks passed
@msporny msporny deleted the further-alignment-with-Controller-Doc branch August 24, 2024 15:37
@msporny msporny added CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. labels Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants