-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reserved confidenceMethod property to the vocabulary — bis #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
requested review from
msporny,
OR13,
selfissued,
decentralgabe and
awoie
as code owners
August 4, 2023 15:19
TallTed
reviewed
Aug 4, 2023
OR13
approved these changes
Aug 4, 2023
mprorock
approved these changes
Aug 4, 2023
awoie
suggested changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one change requested
Co-authored-by: Oliver Terbu <[email protected]>
awoie
approved these changes
Aug 7, 2023
brentzundel
approved these changes
Aug 7, 2023
TallTed
requested changes
Aug 8, 2023
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@msporny I took care of a merge conflict. I think it is now ready to be merged. |
Substantive, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, content-wise, the same PR as #1226, but starting fresh due to the merge problems. See #1226 (comment).
No need to re-review from scratch, just taking over #1226