Add guidance on when to use each type #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
reviewed
Aug 1, 2023
OR13
reviewed
Aug 1, 2023
| <li>Who is the author of this schema? (provided by the <code>issuer</code> property)</li> | ||
| <li>Why should the author be trusted for providing this schema? (provided by the <code>evidence</code> property)</li> | ||
| <li>Is it schema still in use? (provided by the <code>validFrom</code>, <code>validUntil</code>, and <code>credentialStatus</code> properties)</li> | ||
| <li>Has the schema been tampered with? (provided by [[VC-DATA-INTEGRITY]] or [[VC-JWT]])</li> |
There was a problem hiding this comment.
Better to refer to the vc specs dir directly.
There was a problem hiding this comment.
here? https://w3c.github.io/vc-specs-dir/#proof
I don't see vc-cose-jose
There was a problem hiding this comment.
because this has not been merged: w3c/vc-extensions#14
There was a problem hiding this comment.
it would be nice to have a single 'securing mechanism' section but I understand why it's not like that
as an alternative could wait until #191 is merged and then link here to the new content integrity protection section
OR13
reviewed
Aug 1, 2023
index.html
Outdated
| leverage features of the [[VC-DATA-MODEL-2]], answering questions such as: | ||
| <ul> | ||
| <li>Who is the author of this schema? (provided by the <code>issuer</code> property)</li> | ||
| <li>Why should the author be trusted for providing this schema? (provided by the <code>evidence</code> property)</li> |
There was a problem hiding this comment.
Do you have an example of using evidence for this?
If not, please remove the evidence link.
OR13
reviewed
Aug 1, 2023
index.html
Outdated
| <ul> | ||
| <li>Who is the author of this schema? (provided by the <code>issuer</code> property)</li> | ||
| <li>Why should the author be trusted for providing this schema? (provided by the <code>evidence</code> property)</li> | ||
| <li>Is it schema still in use? (provided by the <code>validFrom</code>, <code>validUntil</code>, and <code>credentialStatus</code> properties)</li> |
There was a problem hiding this comment.
Suggested change
| <li>Is it schema still in use? (provided by the <code>validFrom</code>, <code>validUntil</code>, and <code>credentialStatus</code> properties)</li> | |
| <li>Is this schema still valid? (provided by the <code>validFrom</code>, <code>validUntil</code>, and <code>credentialStatus</code> properties)</li> |
OR13
approved these changes
Aug 1, 2023
added 2 commits
August 1, 2023 15:53
andresuribe87
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #173
Preview | Diff