-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keyboard to remove normative acceptance of "completely custom … #3670
Open
detlevhfischer
wants to merge
20
commits into
main
Choose a base branch
from
detlevhfischer-patch-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1750c36
Add two notes/clarifications to 2.1.1 understanding
patrickhlauke e60623a
Add same notes to keyboard-no-exception understanding
patrickhlauke efaacb6
Add example to 2.1.1 understanding for search form with mouse-only su…
patrickhlauke 0ce48a3
Expand note further
patrickhlauke dc067a1
Merge branch 'patrickhlauke-understanding-keyboard-note' of https://g…
patrickhlauke 358e4f5
Merge branch 'main' into patrickhlauke-understanding-keyboard-note
patrickhlauke e45c743
Update understanding/20/keyboard-no-exception.html
mbgower 8f101d8
Update understanding/20/keyboard-no-exception.html
mbgower af59961
Update understanding/20/keyboard-no-exception.html
mbgower 91e9f64
Update understanding/20/keyboard.html
mbgower 25e4261
capitalise SC
patrickhlauke cf1365d
Expanded/reformatted the note
patrickhlauke 39ceb46
Update understanding/20/keyboard-no-exception.html
patrickhlauke 416918f
Update understanding/20/keyboard-no-exception.html
patrickhlauke 62ee758
Update understanding/20/keyboard.html
patrickhlauke 1c04ca4
Update understanding/20/keyboard.html
patrickhlauke 9602cbd
Update keyboard-no-exception.html
detlevhfischer 1f9b6cd
Clean up Detlev's "users of the keyboard interface" suggestion, for n…
patrickhlauke 38cce8a
Change "passes" to "satisfies"
patrickhlauke 6d89105
Update keyboard to remove normative acceptance of "completely custom …
detlevhfischer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially dealing with @patrickhlauke's feedback...
(The rest of his comment is addressed, IMHO, by the text that follows).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that still leaves doubt though about when it does or doesn't, so authors and testers still are none the wiser