Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update G65.html #3951

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Update G65.html #3951

merged 7 commits into from
Sep 16, 2024

Conversation

scottaohara
Copy link
Member

Expand the examples/example descriptions for G65 'providing a breadcrumb trail' to acknowledge the fact that a breadcrumb's current location can be a hyperlink.

closes #3948

Expand the examples for G65 'providing a breadcrumb trail' to acknowledge the fact that a breadcrumb's current location can be a hyperlink.

closes #3948
@scottaohara scottaohara self-assigned this Jul 8, 2024
update working examples to match understanding doc.

add note to indicate none of the hyperlinks in the examples actually go anywhere useful.

other minor code formatting consistency updates
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 3d184fc
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/66e47807f48f9d0008af4e97
😎 Deploy Preview https://deploy-preview-3951--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

revert to ul
change 'unordered list' to just 'list element' to be purposefully non-committal about which list element needs to be used (since it really doesn't matter if the markers are removed)
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with it as is

Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Scott!

@bruce-usab
Copy link
Contributor

@kfranqueiro apologies as I should have flagged this for you on the call. @mbgower asks if he can go ahead and merge it despite the build fails?

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Sep 13, 2024

@kfranqueiro apologies as I should have flagged this for you on the call. @mbgower asks if he can go ahead and merge it despite the build fails?

This branch was out-of-date with main for longer than the new build system was in existence. In such cases, syncing the branch against main will allow the build to run properly. (This happened in another previous case which Mike e-mailed me about; the solution was the same. The only case where this solution would not apply is pull requests targeting branches other than main.)

@mbgower mbgower merged commit d2b0198 into main Sep 16, 2024
5 checks passed
@mbgower mbgower deleted the g65-update branch September 16, 2024 16:24
@mcking65
Copy link

thank you @scottaohara!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify G65 to support implementing current location in a breadcrumb trail as a link with aria-current="page"
9 participants