-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update G65.html #3951
Update G65.html #3951
Conversation
Expand the examples for G65 'providing a breadcrumb trail' to acknowledge the fact that a breadcrumb's current location can be a hyperlink. closes #3948
update working examples to match understanding doc. add note to indicate none of the hyperlinks in the examples actually go anywhere useful. other minor code formatting consistency updates
Co-authored-by: Giacomo Petri <[email protected]>
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
revert to ul
change 'unordered list' to just 'list element' to be purposefully non-committal about which list element needs to be used (since it really doesn't matter if the markers are removed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Scott!
@kfranqueiro apologies as I should have flagged this for you on the call. @mbgower asks if he can go ahead and merge it despite the build fails? |
This branch was out-of-date with main for longer than the new build system was in existence. In such cases, syncing the branch against main will allow the build to run properly. (This happened in another previous case which Mike e-mailed me about; the solution was the same. The only case where this solution would not apply is pull requests targeting branches other than main.) |
thank you @scottaohara!!! |
Expand the examples/example descriptions for G65 'providing a breadcrumb trail' to acknowledge the fact that a breadcrumb's current location can be a hyperlink.
closes #3948