Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rp.name #2159

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Deprecate rp.name #2159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2e3c6
Deprecate rp.name
emlun Sep 27, 2024
fe68eae
Apply review suggestion
emlun Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3593,14 +3593,20 @@ associated with or [=scoped=] to, respectively.
: <dfn>name</dfn>
:: A [=human palatability|human-palatable=] name for the entity. Its function depends on what the {{PublicKeyCredentialEntity}} represents:

- When inherited by {{PublicKeyCredentialRpEntity}} it is a [=human palatability|human-palatable=] identifier for the [=[RP]=], intended only
- \[DEPRECATED] When inherited by {{PublicKeyCredentialRpEntity}} it is a [=human palatability|human-palatable=] identifier for the [=[RP]=], intended only
for display. For example, "ACME Corporation", "Wonderful Widgets, Inc." or "ОАО Примертех".

This member is deprecated because many [=clients=] do not display it,
but it remains a required dictionary member for backwards compatibility.
[=[RPS]=] MAY, as a safe default, set this equal to the [=RP ID=].

- [=[RPS]=] SHOULD perform enforcement, as prescribed in Section 2.3 of
[[!RFC8266]] for the Nickname Profile of the PRECIS FreeformClass [[!RFC8264]],
when setting {{PublicKeyCredentialEntity/name}}'s value, or displaying the value to the user.

- This string MAY contain language and direction metadata. [=[RPS]=] SHOULD consider providing this information. See [[#sctn-strings-langdir]] about how this metadata is encoded.
- This string MAY contain language and direction metadata.
[=[RPS]=] SHOULD consider providing this information if setting the member to a value other than the [=RP ID=].
See [[#sctn-strings-langdir]] about how this metadata is encoded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we getting rid of this stuff? Wasn't that the outcome from TPAC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure we're tracking that aspect in #1643, this PR simply preserves what's currently there (but aligns it with the suggested default).


- [=Clients=] SHOULD perform enforcement, as prescribed in Section 2.3 of
[[!RFC8266]] for the Nickname Profile of the PRECIS FreeformClass [[!RFC8264]],
Expand Down