GetPartitionKey updates #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial proposal
Updates for clarity
Update formatting of url
Updates in phrasing and document organization.
Additional details
Additional content and formatting
Update pr to incorporate reviewer feedback. Co-authored-by: Rob Wu <[email protected]>
Update to reflect reviewer suggestion. Co-authored-by: Rob Wu <[email protected]>
Update to remove reference to Chrome Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Add use case
Added background information on x-site ancestor chain bit
Update language for cookies.remove()
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Co-authored-by: Oliver Dunk <[email protected]>
Add new use case and add clarification to table
Co-authored-by: Rob Wu <[email protected]>
Add language describing logic for determining hasCrossSiteAncestor value when not provided. Update method descriptions to incorporate new language and indicate when errors will be thrown.
Update table
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Add table containing valid partitionKeys. Update language in the background section to be more consistent.
Clarify language surrounding the empty partitionKey
Co-authored-by: bvandersloot-mozilla <[email protected]>
Update language to specify the domain of the cookie's url
Return {} to the table of valid partition keys
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Add table describing inputs for getPartitionKey()
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: Rob Wu <[email protected]>
describe error conditions of new api
Updates to the getPartitionKey() Api: Remove ability to just pass a frameId without a tabId. Update language to describe that an error should be returned when a partitionKey is not serializable.
Update language to include reference to nonce
Rob--W
reviewed
Oct 30, 2024
Add permissions required for getPartitionKey() api
Rob--W
reviewed
Nov 7, 2024
Updating language for host permissions Co-authored-by: Rob Wu <[email protected]>
remove no longer needed permission
Update allowed parameters for getPartitionKey()
Rob--W
reviewed
Nov 13, 2024
Update language for frameId parameter. Co-authored-by: Rob Wu <[email protected]>
Update details on when an error would be returned. Co-authored-by: Rob Wu <[email protected]>
Rob--W
approved these changes
Nov 13, 2024
|
Can I squash and merge or would you like to make more changes? |
|
@Rob--W, feel free to squash and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing the getPartitionKey api, there were two issues that I felt should be updated in the proposal.
The first is removing the ability to allow for just a
frameIdto be used. Allowing this requires the browser to make an assumption on the intended tab which is not explicitly stated in the proposal and could lead to inconsistent behavior between browsers.In chromium there are cases where the CookiePartitionKey of a cookie can be unserializable (if it's got a nonce or the topLevelSite is opaque). The API should return an error in this case to ensure that we are only returning valid keys with this method key.