Skip to content

Commit

Permalink
Update portals patch to fix additional IDL inconsistency
Browse files Browse the repository at this point in the history
See WICG/portals#273 and WICG/portals#275 (patch has been merged but published spec not updated yet)
  • Loading branch information
dontcallmedom committed Aug 4, 2021
1 parent e8b23cd commit 0f03c31
Showing 1 changed file with 39 additions and 9 deletions.
48 changes: 39 additions & 9 deletions ed/idlpatches/portals.idl.patch
Original file line number Diff line number Diff line change
@@ -1,18 +1,48 @@
From f7d204a5a5004b1fc1e8273c3e7b8220dc0a8ff1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= <philip@foolip.org>
Date: Tue, 21 Jul 2020 19:56:23 +0200
Subject: [PATCH] Remove duplicate typedef MessageEventSource
From 821f748ac967de02ffb4cc1258bd625f7702a8fc Mon Sep 17 00:00:00 2001
From: Dominique Hazael-Massieux <dom@w3.org>
Date: Wed, 4 Aug 2021 11:07:56 +0200
Subject: [PATCH] Make consistent with global IDL declarations

Remove duplicate typedef MessageEventSource
https://github.com/WICG/portals/issues/230

Replace PostMessageOptions with StructuredSerializeOptions
https://github.com/WICG/portals/pull/273
https://github.com/WICG/portals/pull/275 (patch has been merged but not published)
---
ed/idl/portals.idl | 2 --
1 file changed, 2 deletions(-)
ed/idl/portals.idl | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ed/idl/portals.idl b/ed/idl/portals.idl
index 0957b2a9c..d0b132889 100644
index 20c655b92..5d85cce66 100644
--- a/ed/idl/portals.idl
+++ b/ed/idl/portals.idl
@@ -43,8 +43,6 @@ dictionary PortalActivateEventInit : EventInit {
@@ -11,13 +11,13 @@ interface HTMLPortalElement : HTMLElement {
[CEReactions] attribute DOMString referrerPolicy;

[NewObject] Promise<undefined> activate(optional PortalActivateOptions options = {});
- undefined postMessage(any message, optional PostMessageOptions options = {});
+ undefined postMessage(any message, optional StructuredSerializeOptions options = {});

attribute EventHandler onmessage;
attribute EventHandler onmessageerror;
};

-dictionary PortalActivateOptions : PostMessageOptions {
+dictionary PortalActivateOptions : StructuredSerializeOptions {
any data;
};

@@ -27,7 +27,7 @@ partial interface Window {

[Exposed=Window]
interface PortalHost : EventTarget {
- undefined postMessage(any message, optional PostMessageOptions options = {});
+ undefined postMessage(any message, optional StructuredSerializeOptions options = {});

attribute EventHandler onmessage;
attribute EventHandler onmessageerror;
@@ -45,8 +45,6 @@ dictionary PortalActivateEventInit : EventInit {
any data = null;
};

Expand All @@ -22,5 +52,5 @@ index 0957b2a9c..d0b132889 100644
attribute EventHandler onportalactivate;
};
--
2.30.0.365.g02bc693789-goog
2.32.0

0 comments on commit 0f03c31

Please sign in to comment.