Add remote track channelCount #3025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
reviewed
Nov 27, 2024
alvestrand
reviewed
Nov 27, 2024
alvestrand
approved these changes
Dec 5, 2024
|
(Jan-Ivar's fiddle from meeting: https://jsfiddle.net/jib1/3Lh9zaxq/) |
henbos
commented
Dec 5, 2024
| <td> | ||
| As a setting, this is the number of channels of the latest | ||
| audio frame received, reflecting the number of | ||
| {{RTCRtpCodec/channels}} that the decoder outputted. |
There was a problem hiding this comment.
Comment from Youenn: make this more clear that you MUST do what the decoder is capable of
jan-ivar
approved these changes
Dec 5, 2024
| @@ -15949,6 +15949,7 @@ <h4 id="x9-3-1-mediatracksupportedconstraints-mediatrackcapabilities-mediatrackc | |||
| double rounded to the tenth decimal place. | |||
| </td> | |||
| </tr> | |||
| <div id="remote-track-settings-channel-count"><!-- ammendment --></div> | |||
There was a problem hiding this comment.
Suggested change
| <div id="remote-track-settings-channel-count"><!-- ammendment --></div> |
not needed since it's an append amendment
Comment on lines
+16680
to
+16681
| <div id="remote-track-settings-channel-count"> | ||
| <tr id="def-constraint-channelCount"> |
There was a problem hiding this comment.
Suggested change
| <div id="remote-track-settings-channel-count"> | |
| <tr id="def-constraint-channelCount"> | |
| <tr id="def-constraint-channelCount"> |
| {{RTCRtpCodec/channels}} that the decoder outputted. | ||
| </td> | ||
| </tr> | ||
| </div> |
There was a problem hiding this comment.
Suggested change
| </div> |
| @@ -1243,6 +1243,21 @@ | |||
| ] | |||
| } | |||
| ], | |||
| "remote-track-settings-channel-count": [ | |||
There was a problem hiding this comment.
Suggested change
| "remote-track-settings-channel-count": [ | |
| "def-constraint-channelCount": [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3011
Preview | Diff