Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable dark mode support in TD document #2029

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jul 4, 2024

This PR adds dark mode support for the document, as specified in the ReSpec documentation.

(For some reason, without this support explicitly enabled, only the examples have a dark background in dark mode, which was always a bit irritating to me until I found the reason for why it is happening. Therefore, this PR makes things a bit more consistent for dark mode users and the spec a bit more pleasant to read.)


Preview | Diff

@danielpeintner
Copy link
Contributor

Note: I am personally not a "dark mode user". Anyhow, if this makes the spec more pleasant to read I suggest to apply this change to all our spec documents.

@lu-zero
Copy link
Contributor

lu-zero commented Jul 4, 2024

It is an usability improvement and given it is just a line to add, I'd land it everywhere.

Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed an improvement! Thanks @JKRhb

@egekorkan egekorkan added the Editorial Issues with no technical impact on implementations label Jul 4, 2024
@egekorkan
Copy link
Contributor

Given an editorial change and approved by one editor, this PR can be merged async after one week if no diverging opinions arise and will not be discussed in the call to save time. See https://github.com/w3c/wot/blob/main/policies/async-decision.md

@egekorkan
Copy link
Contributor

1 week has passed, merging

@egekorkan egekorkan merged commit 28d4bf3 into w3c:main Jul 11, 2024
2 checks passed
@JKRhb JKRhb deleted the dark-mode branch July 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Issues with no technical impact on implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants