Change StatusCode
type to ContentfulStatusCode
#16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
onError
handler, returning ac.json()
response with a contentless status code will throw a type error, asc.json()
requires content. This behavior was introduced in Hono v4.6.15.To address this, changing the
StatusCode
type toContentfulStatusCode
in theonError
handler should resolve the issue. However, can we safely assume thatcurrentStatus
is always a valid status code? Would it be better to maintain an array of valid status codes to check against, rather than simply castingcurrentStatus
toContentfulStatusCode
?