Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delivery milestone 1, IPFS utilities #743

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

dobschal
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#1187

@randombishop randombishop self-assigned this Feb 13, 2023
@randombishop
Copy link
Contributor

Hi @dobschal Thanks for this delivery, I will be working on the evaluation and will get back to you with feedback in next few days...

@randombishop
Copy link
Contributor

Hi @dobschal !
I managed to run tests on the substrate codebase; but it seems like the frontend doesn't come with unit tests.
Did you deliver those? And if yes, can you please document how to run them?
Thank you!

@dobschal
Copy link
Contributor Author

Hey @randombishop ,
the frontend has no unit tests, as it was used for testing the implemented logic on the Substrate chain itself.

@thomasdingler
Copy link

@Noc2 fyi, milestone 1 was delivered.

@randombishop
Copy link
Contributor

Hey @dobschal, thanks for the precision.
No problem with that, but can please you just remove the link to the frontend in the 0c. item deliverables.
I expected to find tests when I found that link.
Thank you

@dobschal
Copy link
Contributor Author

dobschal commented Feb 21, 2023

Thanks @randombishop,
removed the repo from the client app used for testing from 0c.

@randombishop randombishop merged commit 30c56e0 into w3f:master Feb 21, 2023
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@randombishop
Copy link
Contributor

Hey @dobschal happy to accept this delivery.

Please find my evaluation here:
https://github.com/w3f/Grant-Milestone-Delivery/blob/master/evaluations/ipfs_utilities_1_randombishop.md

I will forward your invoice; please expect up to 2 weeks for processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants