Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuma Wallet evaluation milestone 4 #977

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

Ali-Usama
Copy link
Contributor

External Evaluation

The delivery is as per the application and no major issues were found. A detailed evaluation is attached.

Link to the application pull request: w3f/Grants-Program#1414
Link to milestone pull request: #976

@Whisker17
Copy link
Contributor

Hey @Ali-Usama, I am very happy that you are actively participating in external evaluations, but I hope that you can follow the rules set by the GRANT TEAM so that external evaluations can be conducted in a more orderly manner. Please check the replies here and do not open a new external evaluation when you still have unmerged evaluations.

cc @semuelle @dsm-w3f @keeganquigley

@dsm-w3f dsm-w3f self-assigned this Aug 16, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 16, 2023

@Ali-Usama thank you for posting this external evaluation. As mentioned in the previous comment, seem that you was working in two external evaluations at same time. This is against our guidelines. Unless this is not the case, I'll close this evaluation. Any comments on that?

@Ali-Usama
Copy link
Contributor Author

Ali-Usama commented Aug 17, 2023

@Ali-Usama thank you for posting this external evaluation. As mentioned in the previous comment, seem that you was working in two external evaluations at same time. This is against our guidelines. Unless this is not the case, I'll close this evaluation. Any comments on that?

I thought the guidelines are about not opening multiple draft PRs, which I didn't.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Aug 25, 2023

@Ali-Usama thank you for the external evaluation. It is approved. I'll forward your KSM payment. Great job! About the previous discussion in the evaluation, I think there is no problem to be merged since our guidelines by the time that it was open could leave some doubts about the moment that the evaluation is finished.

@dsm-w3f dsm-w3f merged commit d215088 into w3f:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants