-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multisignature management tool #11
Conversation
Hi. Thanks for the application. subscan.io is a nice explorer. I just added it to the tech stack. Are you willing to get paid in BTC? If not I suggest to apply via the general grants program. Regarding the multisignature module, could you link to it? I think there are multiple versions. Also are you aware of the following psp w3f/PSPs#7 |
Thank you for your interest in subscan! We have added the BTC address to the document and revised the project description. We are currently link to as_multi module, and will follow community standards in the future, such as w3f/PSPs#7. |
Sorry for the late reply here. I think in general we are interested in the application. But, as you already pointed out, you should try to make the interface easily adaptable to other multisig solutions (see for example), since there is still a lot under development. I also have a few additional comments/remarks:
|
@Noc2 The adaptable to other multisignature solutions you mentioned is indeed a problem. Our goal is to make a multisignature tool with good compatibility, and there are still many uncertain factors now, so we decided to temporarily delay the project. After the new version of multisignature solutions is determined, we will consider restarting this project. |
Thanks for the update. I think this makes a lot of sense at this stage. I will also reach out to you once we feel the multisig modules have reached a certain majority. Feel free to contribute to the PSP in the meantime. |
Hi @carlhong Would you still be interested in this? At this stage, I think we would be interested in a better UI specifically for the as_multi module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the application. Something to be aware of is that we still only payout btc via the open grants program. Could you therefore change the payment to BTC only? If you want to receive DOTs or KSMs, you can always apply for funding via the treasuries.
An additional question I have is: how are you planning to handle call data. I think that’s currently a big usability problem with polkadot.js.
@Noc2 I've updated payment to receive only BTC. As for call data, we are planing to build an opensourced user-friendly UI to list decoded call data with its hash for users who participated in the multi-signatures. For more convenience, we consider using database or other back-end service to store the index data. Data will be verified by hash on frontend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Could you change the payment to show the amounts in BTC only. I know this way there is some market price risk, but it’s a requirement of the open grants program. (Alternatively you can also apply via the general grants program.) And could you also integrate the information about the call data into the application?
BTC amount and call data info have been updated in application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Hi @carlhong As part of our new grant guidelines, we require that the teams submit the designs and specifications as part of the application Project Details. As David mentioned, we are interested in funding your idea, but in order to accept the proposal, we would need to see more specifics. This will also help us evaluate your submission later. Therefore, please provide:
In addition, please note that we require the submission to contain unit tests for the code logic and integration tests for the overall application. I hope to see an updated proposal soon! |
@mmagician Sorry for the late reply. UI design, backend doc and test part have been added. |
@carlhong Thank you for the updates. It makes it much easier to grasp your proposal now. |
Congratulations. As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly while observing the foundation’s guidelines. To that end, we’ve created a badge for grant-winning teams. Here is a link to the download and guidelines. |
@carlhong any update regarding this grant? You so far only delivered milestone 1 (https://github.com/w3f/Grant-Milestone-Delivery/blob/master/deliveries/multisignature_management_tool_milestone_1.md) Are you still planning to deliver the second milestone? Otherwise we would terminate the grant within the next two weeks. |
@Noc2 Sorry for late reply, we've completed the features required in milestone 2, and the project is in final test stage. We'll pr the delivery as soon as possible after fixing some issues. |
Sounds great. Thanks for the quick reply. |
Grant Application Checklist