Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multisignature management tool #11

Merged
merged 9 commits into from
Sep 11, 2020
Merged

multisignature management tool #11

merged 9 commits into from
Sep 11, 2020

Conversation

carlhong
Copy link
Contributor

@carlhong carlhong commented Apr 3, 2020

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below 30k at the time of submission.

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2020

CLA assistant check
All committers have signed the CLA.

@Noc2
Copy link
Collaborator

Noc2 commented Apr 6, 2020

Hi. Thanks for the application. subscan.io is a nice explorer. I just added it to the tech stack. Are you willing to get paid in BTC? If not I suggest to apply via the general grants program. Regarding the multisignature module, could you link to it? I think there are multiple versions. Also are you aware of the following psp w3f/PSPs#7

@carlhong
Copy link
Contributor Author

carlhong commented Apr 9, 2020

Thank you for your interest in subscan! We have added the BTC address to the document and revised the project description. We are currently link to as_multi module, and will follow community standards in the future, such as w3f/PSPs#7.

RouvenP
RouvenP previously approved these changes Apr 14, 2020
@Noc2
Copy link
Collaborator

Noc2 commented Apr 15, 2020

Sorry for the late reply here. I think in general we are interested in the application. But, as you already pointed out, you should try to make the interface easily adaptable to other multisig solutions (see for example), since there is still a lot under development. I also have a few additional comments/remarks:

  • I noticed that you did not use the template for everything. Could you maybe update at least the milestone according to the template. The tables make it easier to evaluate the deliveries later.
  • Also could you add some basic documentation/readme to every milestone (see the guide of the general program as a reference)
  • If possible integrate unit tests
  • What kind of tutorial are you planning to create and in which language(s)?
  • Is it possible to reduce the overall costs to 3 BTC?

@carlhong
Copy link
Contributor Author

@Noc2 The adaptable to other multisignature solutions you mentioned is indeed a problem. Our goal is to make a multisignature tool with good compatibility, and there are still many uncertain factors now, so we decided to temporarily delay the project. After the new version of multisignature solutions is determined, we will consider restarting this project.

@carlhong carlhong closed this Apr 16, 2020
@Noc2
Copy link
Collaborator

Noc2 commented Apr 16, 2020

Thanks for the update. I think this makes a lot of sense at this stage. I will also reach out to you once we feel the multisig modules have reached a certain majority. Feel free to contribute to the PSP in the meantime.

@Noc2
Copy link
Collaborator

Noc2 commented Aug 11, 2020

Hi @carlhong Would you still be interested in this? At this stage, I think we would be interested in a better UI specifically for the as_multi module.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the application. Something to be aware of is that we still only payout btc via the open grants program. Could you therefore change the payment to BTC only? If you want to receive DOTs or KSMs, you can always apply for funding via the treasuries.
An additional question I have is: how are you planning to handle call data. I think that’s currently a big usability problem with polkadot.js.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Aug 27, 2020
@carlhong
Copy link
Contributor Author

@Noc2 I've updated payment to receive only BTC. As for call data, we are planing to build an opensourced user-friendly UI to list decoded call data with its hash for users who participated in the multi-signatures. For more convenience, we consider using database or other back-end service to store the index data. Data will be verified by hash on frontend.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Could you change the payment to show the amounts in BTC only. I know this way there is some market price risk, but it’s a requirement of the open grants program. (Alternatively you can also apply via the general grants program.) And could you also integrate the information about the call data into the application?

@carlhong
Copy link
Contributor Author

carlhong commented Sep 1, 2020

BTC amount and call data info have been updated in application

Noc2
Noc2 previously approved these changes Sep 1, 2020
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Sep 1, 2020
@mmagician
Copy link
Contributor

Hi @carlhong

As part of our new grant guidelines, we require that the teams submit the designs and specifications as part of the application Project Details. As David mentioned, we are interested in funding your idea, but in order to accept the proposal, we would need to see more specifics. This will also help us evaluate your submission later.

Therefore, please provide:

  • the envisioned UI designs
  • more technical details on how you plan to use the database/backend

In addition, please note that we require the submission to contain unit tests for the code logic and integration tests for the overall application.

I hope to see an updated proposal soon!

@carlhong
Copy link
Contributor Author

@mmagician Sorry for the late reply. UI design, backend doc and test part have been added.

@mmagician
Copy link
Contributor

@carlhong Thank you for the updates. It makes it much easier to grasp your proposal now.

@mmagician mmagician self-requested a review September 11, 2020 09:09
@carlhong carlhong requested a review from RouvenP September 11, 2020 09:47
@RouvenP RouvenP merged commit 140b867 into w3f:master Sep 11, 2020
@Noc2
Copy link
Collaborator

Noc2 commented Sep 14, 2020

Congratulations. As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly while observing the foundation’s guidelines. To that end, we’ve created a badge for grant-winning teams. Here is a link to the download and guidelines.

If you are interested in making an announcement about your grant and you would like us to broadcast it on our media channels then please get in touch with us at [email protected] prior to making the announcement (at least two weeks notice is preferred) so that we can coordinate on timing and content.

Noc2 pushed a commit that referenced this pull request Nov 19, 2020
@Noc2
Copy link
Collaborator

Noc2 commented Jul 29, 2021

@carlhong any update regarding this grant? You so far only delivered milestone 1 (https://github.com/w3f/Grant-Milestone-Delivery/blob/master/deliveries/multisignature_management_tool_milestone_1.md) Are you still planning to deliver the second milestone? Otherwise we would terminate the grant within the next two weeks.

@carlhong
Copy link
Contributor Author

@Noc2 Sorry for late reply, we've completed the features required in milestone 2, and the project is in final test stage. We'll pr the delivery as soon as possible after fixing some issues.

@Noc2
Copy link
Collaborator

Noc2 commented Jul 29, 2021

Sounds great. Thanks for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants