Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit HRMP opening info #5494

Closed
wants to merge 11 commits into from
Closed

Edit HRMP opening info #5494

wants to merge 11 commits into from

Conversation

filippoweb3
Copy link
Contributor

@filippoweb3 filippoweb3 commented Jan 10, 2024

Removed the info about using the force_transfer within the batchAll call, as now the track is General Admin (not Root), which does not have permissions.

Added info about transferring funds deposit (20 DOT + existential deposit + fees) to the system parachain's sovereign account before opening the channel and doing the proposal.

@filippoweb3 filippoweb3 self-assigned this Jan 10, 2024
@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Jan 10, 2024
@filippoweb3 filippoweb3 linked an issue Jan 10, 2024 that may be closed by this pull request
@filippoweb3
Copy link
Contributor Author

Hey @lrazovic I updated the info about opening HRMP channels. Let me know if there is additional info to add.

@filippoweb3 filippoweb3 requested a review from DrW3RK January 10, 2024 12:28
@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Jan 10, 2024
Copy link
Collaborator

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that after runtime 1,001,000, chains will not need any deposit at all for channels with system chains (and should be fine without any balance in their accounts) and there will be a poke_deposit function that will refund any existing deposits.

docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Show resolved Hide resolved
@filippoweb3
Copy link
Contributor Author

@DrW3RK this PR is good to go, I fixed some old links and updated the info using the documentation provided by Polimec. @lrazovic provided some feedback I implemented.

Copy link

@JuaniRios JuaniRios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this would have been in the docs, it would have saved me a lot of time delving into the code. I believe these changes will also benefit future devs.

docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
docs/build/build-hrmp-channels.md Outdated Show resolved Hide resolved
Each parachain is to use its own governance process to execute this. The call will be executed on
the Relay Chain.
Each parachain is to use its governance process to execute this. The call will be executed on the
Relay Chain.
Copy link

@JuaniRios JuaniRios Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is to be made only through governance, then why do we have the xcm instruction HrmpNewChannelOpenRequest sent by the relay as a notification?
At Polimec we are using this to do automatic channel opening, without going through governance.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we had to modify the xcm-executor because it had that instruction left empty, so maybe that change can happen once the executor adds an implementation for those instructions 🤔

@joepetrowski
Copy link
Collaborator

#5498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HRMP documentation
3 participants