-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit HRMP opening info #5494
Edit HRMP opening info #5494
Conversation
Hey @lrazovic I updated the info about opening HRMP channels. Let me know if there is additional info to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that after runtime 1,001,000, chains will not need any deposit at all for channels with system chains (and should be fine without any balance in their accounts) and there will be a poke_deposit
function that will refund any existing deposits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this would have been in the docs, it would have saved me a lot of time delving into the code. I believe these changes will also benefit future devs.
Each parachain is to use its own governance process to execute this. The call will be executed on | ||
the Relay Chain. | ||
Each parachain is to use its governance process to execute this. The call will be executed on the | ||
Relay Chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is to be made only through governance, then why do we have the xcm instruction HrmpNewChannelOpenRequest sent by the relay as a notification?
At Polimec we are using this to do automatic channel opening, without going through governance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we had to modify the xcm-executor because it had that instruction left empty, so maybe that change can happen once the executor adds an implementation for those instructions 🤔
Co-authored-by: Juan Ignacio Rios <[email protected]>
Co-authored-by: Juan Ignacio Rios <[email protected]>
Co-authored-by: Juan Ignacio Rios <[email protected]>
Removed the info about using the
force_transfer
within the batchAll call, as now the track is General Admin (not Root), which does not have permissions.Added info about transferring funds deposit (20 DOT + existential deposit + fees) to the system parachain's sovereign account before opening the channel and doing the proposal.