-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial treasury docs #5678
Initial treasury docs #5678
Conversation
@CrackTheCode016 I linked the issue about spend local calls. I think we can address that issue with this PR. Wdyt? |
@filippoweb3 yup we can! I think I'll split this into two PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added conditional rendering for Kusama, some minor edits and some suggestions to make the additions a bit more clear to the reader. Let me know what you think!
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
Co-authored-by: Filippo <[email protected]>
@filippoweb3 Besides the liquidity aspect, the PR is ready, but we can wait on that specifically before reviewing again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for implementing the feedback!
3. The asset has a set conversion rate, as per OpenGov referenda on the Treasurer track (set via the | ||
asset rate pallet). This conversion rate defines a fixed-rate representation for converting from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? How can the conversion rate be fixed, given the assets are volatile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant a fixed point, not a fixed rate, although I think that is the case anyway, as the rate is a FixedI128
set in the StorageMap and can be updated. not sure what the strategy is to maintain it unless I am misunderstanding something.
For more detail, take a look here, and how the rate is set in the pallet: https://github.com/paritytech/polkadot-sdk/blob/475e7a147676a4e7a9d255ddc7969dd35ea22882/substrate/frame/asset-rate/src/lib.rs#L18
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
Co-authored-by: Radha <[email protected]>
spend_local
call rather than thespend
call