Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test no_std builds on a target lacking std #94

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

pinkforest
Copy link
Contributor

This has bitten me more times than I care to admit :)

So here is a build-test for no_std that ensures build on a target that lacks std - default target would have std available.

It also tests all the features properly when / if introduced automatically unless excluded as std e.g. getrandom / std

We use the same in curve25519-dalek

@koute koute requested a review from burdges September 22, 2023 05:53
@burdges
Copy link
Collaborator

burdges commented Sep 23, 2023

LGTM but can we trigger this manually?

@burdges burdges merged commit 38035b5 into w3f:master Sep 23, 2023
5 checks passed
@pinkforest
Copy link
Contributor Author

Just needs workflow_dispatch: at top under on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants