Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo site bugs #118

Open
rowanwins opened this issue Jan 13, 2020 · 1 comment
Open

Demo site bugs #118

rowanwins opened this issue Jan 13, 2020 · 1 comment

Comments

@rowanwins
Copy link
Collaborator

rowanwins commented Jan 13, 2020 •
edited
Loading

So in investigating why we were getting different results in different spots (eg this comment here) it turns out the demo site was passing the geojson into leaflet and then using leaflets toGeoJson method the recreate the geojson being passed into the martinez operation.

I suspect this caused some mutations of the input data and is why we're getting a mismatch in the demo site vs codepen vs node etc...

So I'll open a PR for the demo site and we'll need to revisit which issues #111 actually closes for real :(

cc @w8r & @bluenote10
@rowanwins rowanwins mentioned this issue Jan 13, 2020
Merged
@bluenote10 bluenote10 mentioned this issue Jan 13, 2020
Open
@rowanwins
Copy link
Collaborator Author

Turns out the codepen does this too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rowanwins