Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original geojson as input #119

Merged
merged 5 commits into from
Feb 23, 2020
Merged

Use original geojson as input #119

merged 5 commits into from
Feb 23, 2020

Conversation

rowanwins
Copy link
Collaborator

This resolves the issue identified in #118 by using the original geojson where it's available rather than stuff that's been passed through leaflet.

@w8r
Copy link
Owner

w8r commented Jan 13, 2020

But leaflet is not supposed to do anything with it, the clipping and path simplification are only done in the rendering and don't affect the initial latLngs

@rowanwins
Copy link
Collaborator Author

I does seems strange @w8r but I'm having a hard time pinning things down.

I just noticed that the codepen used the same behaviour of passing things into leaflet and then back again... so perhaps it's not what I thought...

Does the #110 set of polygons work for you when you run the demo locally?

@rowanwins
Copy link
Collaborator Author

So we could possibly close this - although I think my preference would be to still merge it and use the raw geojson rather than passing it into leaflet and back again, just seems a bit less risky.

@bluenote10
Copy link
Collaborator

Does that mean there is a different cause of the modified input values we have seen in #111 / comment or does this PR solve that?

@rowanwins
Copy link
Collaborator Author

There are also some lines in the current master demo site which stringify and parse the input data so that could be responsible also...

@rowanwins
Copy link
Collaborator Author

It seems like #85 is impacted by the demo site change. Works on the master branch, but not on this branch.

@w8r w8r merged commit 01990ed into master Feb 23, 2020
@w8r w8r deleted the demo-site-fix branch February 23, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants