Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes related to loading diaries and storing part 2 output #1249

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Jan 17, 2025

Note: I do not update documentation because:

  • The logic of re-loading activity diaries is only for internal workings of GGIR and not of direct relevance to user.
  • The other points concern bugs fixes and not functional changes.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Clean code has been attempted, e.g. intuitive object names and no code redundancy.
  • Documentation updated:
    • Function documentation
    • Chapter vignettes for GitHub IO
    • Vignettes for CRAN
  • Corresponding issue tagged in PR message. If no issue exist, please create an issue and tag it.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.
  • GGIR parameters were added/removed. If yes, please also complete checklist below.

@vincentvanhees vincentvanhees marked this pull request as ready for review January 17, 2025 14:29
@vincentvanhees vincentvanhees merged commit 69e9dda into master Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant