Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue53 checksum fail #54

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Issue53 checksum fail #54

merged 2 commits into from
Dec 5, 2023

Conversation

l-k-
Copy link
Collaborator

@l-k- l-k- commented Dec 5, 2023 •
edited
Loading

Addresses issue #53

This PR handles corrupt cwa blocks (blocks with mismatched checksum), in various parts of the file, and in various parts of the requested [start, end) range.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6ed29a4) 87.39% compared to head (8be2db6) 90.03%.

Files Patch % Lines
R/readAxivity.R 92.47% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   87.39%   90.03%   +2.63%     
==========================================
  Files           9        9              
  Lines         833      903      +70     
==========================================
+ Hits          728      813      +85     
+ Misses        105       90      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l-k- l-k- force-pushed the issue53-checksum-fail branch 4 times, most recently from f56a038 to c403aed Compare December 5, 2023 05:08
@l-k- l-k- marked this pull request as draft December 5, 2023 05:11
@l-k- l-k- force-pushed the issue53-checksum-fail branch from c403aed to 8be2db6 Compare December 5, 2023 05:30
@l-k- l-k- marked this pull request as ready for review December 5, 2023 05:31
vincentvanhees
vincentvanhees approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@vincentvanhees vincentvanhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lena, this looks great. I went through the changes and have not been able to find anything that I do not understand or that does not work.

@vincentvanhees vincentvanhees merged commit bfcccab into main Dec 5, 2023
10 checks passed
@l-k- l-k- deleted the issue53-checksum-fail branch December 5, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentvanhees vincentvanhees vincentvanhees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-k- @vincentvanhees