Fix for invalid JSON output (variable scoping), when we specify multiple rule files, and have hits from multiple rule files. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if we have hits from each file because the self.first_json_output is currently created in the scope of executeRuleset which is called for each rule file, meaning that we create JSON output with missing comma's between alerts. This fix scopes first_json_output at the class level and fixes the issue.
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple rule files are specified, invalid JSON output is created… if we have hits from each file because the self.first_json_output is currently created in the scope of executeRuleset which is called for each rule file, meaning that we create JSON output with missing comma's between alerts. This fix scopes first_json_output at the class level and fixes the issue.