add note about default socket to macos installation instructions #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shouldn't resolve #462. Even with that, it still doesn't work. |
|
Also, I think this PR would be superseded with #490 which actually makes dive honor the docker context :) |
Sweet. I'll just close this :) |
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
…oodman#490) This patch adds support for detecting the "docker host" to connect to which is set in the current docker context. One can have multiple such contexts and one of them can be activated via `docker context use <context-name>`. Fixes wagoodman#397 Fixes wagoodman#408 Fixes wagoodman#412 Fixes wagoodman#463 Fixes wagoodman#495 Co-authored-by: Rajiv Kushwaha <[email protected]>
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
…oodman#490) This patch adds support for detecting the "docker host" to connect to which is set in the current docker context. One can have multiple such contexts and one of them can be activated via `docker context use <context-name>`. Fixes wagoodman#397 Fixes wagoodman#408 Fixes wagoodman#412 Fixes wagoodman#463 Fixes wagoodman#495 Co-authored-by: Rajiv Kushwaha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This note should resolve #462 - and basically addresses the use case where MacOS users don't have the default socket option enabled in Docker Desktop - causing the (somewhat ambiguous) error
Error response from daemon: pull access deniedEdit
and also resolve #453