Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): update curl commands #533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

guoard
Copy link

@guoard guoard commented Jun 11, 2024

Hi,

Wrapping the endpoints in " characters prevents zsh from interpreting them when copy-pasting the command.

The -f option ensures that an invalid .deb or .rpm file is not created if the curl command fails to download the actual file.

@justsaumit
Copy link

justsaumit commented Nov 2, 2024

Faced this exact issue, resolved it by enclosing in double quotes to ensure $DIVE_VERSION expands correctly.
curl -OL "https://github.com/wagoodman/dive/releases/download/v${DIVE_VERSION}/dive_${DIVE_VERSION}_linux_amd64.deb"

Addition of -f flag in this PR would also be beneficial. Thank you @guoard!

joschi added a commit to joschi/dive that referenced this pull request Nov 6, 2024
joschi added a commit to joschi/dive that referenced this pull request Nov 7, 2024
joschi added a commit to joschi/dive that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants