-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#24 - Use script tag for prompts and admin path #41
Merged
tomusher
merged 7 commits into
wagtail:main
from
ianmeigh:refactor/#24-use-script-tag-for-prompts-and-admin-path
Dec 20, 2023
Merged
#24 - Use script tag for prompts and admin path #41
tomusher
merged 7 commits into
wagtail:main
from
ianmeigh:refactor/#24-use-script-tag-for-prompts-and-admin-path
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin path used by the editor magic wand and the prompts are now read from a script tag.
tm-kn
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, left a few comments! Thanks!
tomusher
reviewed
Dec 15, 2023
tomusher
reviewed
Dec 15, 2023
Removed node package 'humps'.
Thanks @ianmeigh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Admin path used by the editor magic wand and the prompts are no longer assigned as JavaScript variables in the window global and get added to the DOM in a script tag (id = wagtail-ai-config).
Closes #24.