Compile assets in nightly tests, and use Node 20 everywhere #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Should we update the |
|
oh, I missed that one. will do |
zerolab
force-pushed
the
chore/compiled-assets-in-nightly-tests
branch
from
1e267d1 to
db366dc
Compare
|
@tomusher done. and rebased to keep the commits clean |
zerolab
changed the title
zerolab
force-pushed
the
chore/compiled-assets-in-nightly-tests
branch
from
db366dc to
24d6344
Compare
|
Perfect thanks @zerolab ! |
|
Cheers @tomusher! I think with this we're ready for a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22
Also standardises on Node 20 (LTS) everywhere. We had node 21 in docs and
devcontainer.json, Node 16 in.nvmrcand Node 18 as default in the GitHub Actions (ref)