Fix rate limit custom number #1153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
force-pushed
the
bugfix/rate-limit-param
branch
from
abdb0d2 to
f9aefe9
Compare
gandarez
force-pushed
the
bugfix/rate-limit-param
branch
2 times, most recently
from
3fa9eca to
7ab03d6
Compare
leekib
reviewed
Jan 6, 2025
USAGE.md
Outdated
| @@ -91,7 +91,7 @@ some/submodule/name = new project name | |||
| | api_key | Your wakatime api key. | _string_ | | | |||
| | api_key_vault_cmd | A command to get your api key, perhaps from some sort of secure vault. Actually a space-separated list of an executable and its arguments. Executables in PATH can be referred to by their basenames. Shell syntax not supported. | _string_ | | | |||
| | api_url | The WakaTime API base url. | _string_ | <https://api.wakatime.com/api/v1> | | |||
| | heartbeat_rate_limit_seconds | Rate limit sending heartbeats to the API once per duration. Set to 0 to disable rate limiting. | _int_ | `120` | | |||
| | heartbeat_rate_limit_seconds | Rate limit sending heartbeats to the API once per duration. Set to -1 to disable rate limiting. | _int_ | `120` | | |||
There was a problem hiding this comment.
It seems there's a same issue with the timeout as well.
gandarez
force-pushed
the
bugfix/rate-limit-param
branch
from
7ab03d6 to
ce559c9
Compare
gandarez
commented
Jan 6, 2025
|
Closing in favor of #1154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes setting custom number for
heartbeat-rate-limit-seconds. Currently any value informed from config is completely ignored as the default value for the flag is 120. The easiest way was to make the default value zero asvipertools.FirstNonEmptyInt()only returns valid values that are not equal to zero and making it parsing correctly when set by flag or config file. @alanhamlett the drawback here is to instead of setting rate limit to zero it needs to be set to -1 (or any negative number) to get disabled.Fixes #1147