feat: use the lowest latency peer for light protocols #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
we now maybe pinging a peer from two different places: KeepAliveManager and while finding lowest latency peer there doesn't seem to be a direct way to reuse a stream for pinging
fryorcraken
reviewed
Aug 30, 2023
| @@ -16,6 +19,30 @@ export function selectRandomPeer(peers: Peer[]): Peer | undefined { | |||
| return peers[index]; | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
| * @param ping The libp2p ping service's ping function | |||
There was a problem hiding this comment.
As discussed, I'd just re-use the keep alive functionality at this point in time.
|
superseded by #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During selection of peers to be used for light protocols, the selection currently happens randomly. This is not ideal, as we might potentially be communicating with a higher latency node, while an option to use a faster node might exist.
Ref: #1465 #1497
Solution
Instead of randomly selecting peers, ping all peers and select the peer with the lowest latency.
Notes
TODO