chore: refactor Filter to an event-based API

[danisharora099]

Problem

For the Filter API, we currently rely on:

• passing (and internally maintaining) callbacks
• first createSusbcription, and then call await subscribe(Decoder, Callback) which is not the most intuitive API

Solution

• switch to an event-listener based model which is more intuitive for subscription-based activities
• dispatch errors using the same event listener
• cleans up our protocol implementation class

Notes

new API:

const subscription = waku.filter.createSusbcription([TestDecoder])
subscription.addEventListener(contentTopic, (event) => {
const {data, error} = event.detail;
   if (data) {
      // handle data here
   } else if (error) {
      // handle error here
   }
});

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
Waku core	79.34 KB (+0.06% 🔺)	1.6 s (+0.06% 🔺)	369 ms (+20.44% 🔺)	2 s
Waku Simple Light Node	243.14 KB (+0.13% 🔺)	4.9 s (+0.13% 🔺)	604 ms (+23.69% 🔺)	5.5 s
ECIES encryption	73.66 KB (+0.02% 🔺)	1.5 s (+0.02% 🔺)	355 ms (-25.32% 🔽)	1.9 s
Symmetric encryption	73.65 KB (+0.02% 🔺)	1.5 s (+0.02% 🔺)	199 ms (-13.23% 🔽)	1.7 s
DNS discovery	121.92 KB (0%)	2.5 s (0%)	276 ms (-7.79% 🔽)	2.8 s
Privacy preserving protocols	127.1 KB (+0.01% 🔺)	2.6 s (+0.01% 🔺)	461 ms (+92.6% 🔺)	3.1 s
Light protocols	77.4 KB (+0.72% 🔺)	1.6 s (+0.72% 🔺)	251 ms (+24.63% 🔺)	1.8 s
History retrieval protocols	75.78 KB (+0.07% 🔺)	1.6 s (+0.07% 🔺)	179 ms (-51.89% 🔽)	1.7 s
Deterministic Message Hashing	5.92 KB (0%)	119 ms (0%)	43 ms (-15.71% 🔽)	161 ms

[weboko]

This function and Filter.onRequest should be updated to allow listeners being notified about errors as I mentioned here https://github.com/waku-org/js-waku/pull/1682/files#r1387338041

[danisharora099]

Refactored others.
For onRequest, this can be tricky since it's an async operation and outside the general flow of subscription. Perhaps introducing a callback/event-emission from the Filter class should be incorporated.
We also cannot use the same event-emitter as Subscription, since its segregated by the pubsub topic.
I'd prefer to revisit this once autosharding is implemented.

[weboko]

Let's split it into a follow-up task

[fryorcraken]

We should move away from try/catch in favour of return error enum

[danisharora099]

tracked part of #1725 and #1694