feat: add function to validate autoshard content topic #1711
Conversation
size-limit report 📦
|
| @@ -0,0 +1,88 @@ | |||
| import { expect } from "chai"; | |||
There was a problem hiding this comment.
You can keep this test in packages/tests similarly how other utils are done there.
https://github.com/waku-org/js-waku/blob/master/packages/tests/tests/utils.spec.ts
There was a problem hiding this comment.
@weboko I tired this but now it takes a lot longer to run the unit tests for this function. IMO it shouldn't share a test file that needs docker running in order to not fail.
Plus the tests in that package feel more like integration tests, whereas here we have straightforward unit tests.
| * Given a string, will throw an error if it is not formatted as a valid content topic for autosharding based on https://rfc.vac.dev/spec/51/ | ||
| * @param contentTopic String to validate | ||
| */ | ||
| export function validateContentTopic(contentTopic: string): void { |
There was a problem hiding this comment.
nitpick: when the method throws an error on failed check, then I believe the ensure prefix is more commonly used.
There was a problem hiding this comment.
renamed to ensureValidContentTopic
adklempner
force-pushed
the
adklempner/validate-content-topics
branch
2 times, most recently
from
497c0ef to
0ff58e0
Compare
adklempner
force-pushed
the
adklempner/validate-content-topics
branch
from
0ff58e0 to
1bc1eb5
Compare
Problem
There is currently no function for validating content topics used for autosharding
Solution
This PR adds a function to sharding utils which validates that a string is a valid content topic in the context of autosharding
Notes