chore: minor refactoring for protocols #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
danisharora099
force-pushed
the
chore/cleanup
branch
from
ccadd63 to
2b45d34
Compare
adklempner
reviewed
Dec 19, 2023
fryorcraken
reviewed
Dec 19, 2023
| maxBootstrapPeers | ||
| ); | ||
|
|
||
| const sortedFilteredPeers = await sortPeersByLatency( |
There was a problem hiding this comment.
Documentation of the function needs to be updated.
There was a problem hiding this comment.
Can you elaborate?
Doc for sortPeersByLatency was updated.
For the parent function getPeers, it has a generic definition that wasn't falsy. Updated it for more verbosity: 02aeab8
There was a problem hiding this comment.
@fryorcraken merging this now
please let me know if you would prefer any follow up -- thanks!
danisharora099
force-pushed
the
chore/cleanup
branch
from
babefc7 to
13ce861
Compare
adklempner
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseProtocolhousedgetPeeras well asgetPeerswith very close naming.getPeersis used to find peers for a protocol, & filter according to discovery mechanism prioritization.getPeersimply found lowest latency peer for the protocol (while this was not required by the way it was being used after we introducedgetPeers)This PR:
getPeerfunction and directly usespeerStore.get(peerId)to find a peerpeerIdis made mandatory on the params for peer-exchange querygetPeersis used in all other protocols and the lowest latency sorting is addedNotes:
selectPeersForProtocol& refactored test added