feat: migrates e2e tests to use rest instead of rpc #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
adklempner
force-pushed
the
feat/rpc-to-rest
branch
from
93b27f0 to
6009af7
Compare
danisharora099
approved these changes
Feb 19, 2024
| @@ -210,13 +208,26 @@ export class ServiceNode { | |||
| async peers(): Promise<string[]> { | |||
| this.checkProcess(); | |||
|
|
|||
| return this.rpcCall<string[]>("get_waku_v2_admin_v1_peers", []); | |||
| return this.restCall<string[]>( | |||
| "/admin/v1/peers", | |||
There was a problem hiding this comment.
nit: we could add all endpoint strings part of an object/enum/constants
alrevuelta
reviewed
Feb 29, 2024
| import pRetry from "p-retry"; | ||
| import portfinder from "portfinder"; | ||
|
|
||
| import { | ||
| Args, | ||
| KeyPair, | ||
| LogLevel, | ||
| MessageRpcQuery, |
There was a problem hiding this comment.
Can see a bunch of "rpc" references here and there. Perhaps rename to rest? eg MessageRpcQuery?
| @@ -233,9 +244,8 @@ export class ServiceNode { | |||
| async messages( | |||
| pubsubTopic: string = DefaultPubsubTopic | |||
| ): Promise<MessageRpcResponse[]> { | |||
| pubsubTopic = encodeURIComponent(pubsubTopic); | |||
| return this.restCall<MessageRpcResponse[]>( | |||
There was a problem hiding this comment.
same MessageRpcResponse? rename to rest?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
nwaku is deprecating the JSON RPC api for communicating with a node. js-waku uses the api when running e2e tests.
Solution
/privateNotes